Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic usage of preg_replace #1

Open
wordish opened this issue Jun 19, 2024 · 1 comment
Open

Dynamic usage of preg_replace #1

wordish opened this issue Jun 19, 2024 · 1 comment

Comments

@wordish
Copy link

wordish commented Jun 19, 2024

Dynamic usage of preg_replace is not ideal.
Please check manually for /e modifier or user input

File Line Col
/controller.php 115 16
/controller.php 162 16
/controller.php 216 16
/controller.php 275 29
/controller.php 283 33
/controller.php 287 33
/controller.php 295 37
@noogen
Copy link
Contributor

noogen commented Jun 20, 2024

I know what you're suggesting, but there are some complex regex that were (disclaimer/accredited in function comments); thus, making it hard to convert. I also read that preg_replace /e modifier has been deprecated since php 5.5

If it's just simply preg_replace_callback conversion or empty string check, please add pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants