Added check whether callback is specified, and published version 1.0.1

nielsboogaard · Nov 25, 2019 · 0abdc9d · 0abdc9d
1 parent c3df1d3
commit 0abdc9d
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 21 deletions.
diff --git a/dist/filepond-plugin-manage-metadata.esm.js b/dist/filepond-plugin-manage-metadata.esm.js
@@ -63,12 +63,18 @@ const plugin = fpAPI => {
       );
       const onManageMetadata = root.query('GET_ON_MANAGE_METADATA');
 
-      registerManageMetadataComponent(
-        item,
-        root.element,
-        labelButtonManageMetadata,
-        onManageMetadata
-      );
+      if (onManageMetadata) {
+        registerManageMetadataComponent(
+          item,
+          root.element,
+          labelButtonManageMetadata,
+          onManageMetadata
+        );
+      } else {
+        console.error(
+          "No 'onManageMetadata' callback method specified for FilePondPluginManageMetadata! See https://github.com/nielsboogaard/filepond-plugin-manage-metadata for more instructions."
+        );
+      }
     };
 
     // start writing

diff --git a/dist/filepond-plugin-manage-metadata.esm.min.js b/dist/filepond-plugin-manage-metadata.esm.min.js
diff --git a/dist/filepond-plugin-manage-metadata.js b/dist/filepond-plugin-manage-metadata.js
@@ -69,12 +69,19 @@
           'GET_LABEL_BUTTON_MANAGE_METADATA'
         );
         const onManageMetadata = root.query('GET_ON_MANAGE_METADATA');
-        registerManageMetadataComponent(
-          item,
-          root.element,
-          labelButtonManageMetadata,
-          onManageMetadata
-        );
+
+        if (onManageMetadata) {
+          registerManageMetadataComponent(
+            item,
+            root.element,
+            labelButtonManageMetadata,
+            onManageMetadata
+          );
+        } else {
+          console.error(
+            "No 'onManageMetadata' callback method specified for FilePondPluginManageMetadata! See https://github.com/nielsboogaard/filepond-plugin-manage-metadata for more instructions."
+          );
+        }
       }; // start writing
 
       view.registerWriter(

diff --git a/dist/filepond-plugin-manage-metadata.min.js b/dist/filepond-plugin-manage-metadata.min.js
diff --git a/index.html b/index.html
@@ -54,11 +54,7 @@ <h3>Manage Metadata plugin for FilePond demo</h3>
             FilePond.registerPlugin(FilePondPluginManageMetadata);
 
             // Create the FilePond instance
-            const pond = FilePond.create(inputElement, {
-                onManageMetadata: function(item) {
-                    console.log('onManageMetadata hook called', item);
-                }
-            });
+            const pond = FilePond.create(inputElement);
             pond.addFile('./nature.jpg');
         }
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "filepond-plugin-manage-metadata",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "description": "Manage Metadata Plugin for FilePond",
     "license": "MIT",
     "author": {

diff --git a/src/js/index.js b/src/js/index.js
@@ -31,7 +31,11 @@ const plugin = fpAPI => {
             const labelButtonManageMetadata = root.query('GET_LABEL_BUTTON_MANAGE_METADATA');
             const onManageMetadata = root.query('GET_ON_MANAGE_METADATA');
 
-            registerManageMetadataComponent(item, root.element, labelButtonManageMetadata, onManageMetadata);
+            if (onManageMetadata) {
+                registerManageMetadataComponent(item, root.element, labelButtonManageMetadata, onManageMetadata);
+            } else {
+                console.error("No 'onManageMetadata' callback method specified for FilePondPluginManageMetadata! See https://github.com/nielsboogaard/filepond-plugin-manage-metadata for more instructions.");
+            }
         };
 
         // start writing