Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Device Command with "/" in command name not creating switch #350

Open
tmurfin opened this issue Mar 2, 2021 · 10 comments
Open

[BUG] Device Command with "/" in command name not creating switch #350

tmurfin opened this issue Mar 2, 2021 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@tmurfin
Copy link

tmurfin commented Mar 2, 2021

Describe the bug
I have a device that is giving me the command InputDisc/Phono but it says "No function list found on startup when i try to make a switch to be able to select the input, because the "/" is a modifier to make toggle commands, so I can not select this because the "/" is a modifier to make toggle commands, so I can not select this input on my device.

To Reproduce
Steps to reproduce the behavior

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Screen Shot 2021-03-01 at 11 03 30 PM
Screen Shot 2021-03-01 at 11 03 10 PM

IOS (please complete the following information):

  • Version
  • Device:

Logs
Your log in debug mode (-D option)

Config
{
"name": "Harmony Hub",
"hubIP": "",
"hubName": "Harmony Hub",
"TVAccessory": false,
"switchAccessories": false,
"publishGeneralMuteSwitch": false,
"publishGeneralVolumeSlider": false,
"publishGeneralVolumeSwitches": false,
"linkVolumeControlToTV": false,
"publishSwitchActivitiesAsIndividualAccessories": true,
"devicesToPublishAsAccessoriesSwitch": [
"NAD Amp|Power;PowerOn/PowerOff",
"NAD Amp|Mute;Mute",
"NAD Amp|Volume Up;VolumeUp",
"NAD Amp|Volume Down;VolumeDown",
"NAD Amp|Media Player;InputMp",
"NAD Amp|Video;InputVideo",
"NAD Amp|Turntable;InputDisc/Phono"
],
"publishDevicesAsIndividualAccessories": false,
"showCommandsAtStartup": true,
"platform": "HarmonyHubWebSocket"
},

Additional context
Add any other context about the problem here.

@tmurfin tmurfin added the bug Something isn't working label Mar 2, 2021
@tmurfin tmurfin changed the title [BUG] [BUG] Device Command with "/" in command name not creating switch Mar 2, 2021
@nicoduj
Copy link
Owner

nicoduj commented Mar 2, 2021

Hi,

thanks for reporting. Will try to sanitise names in order to be compliant. Meanwhile, can't you rename it in harmony app ?

@nicoduj nicoduj added this to the 1.5.2 milestone Mar 2, 2021
@tmurfin
Copy link
Author

tmurfin commented Mar 2, 2021

I was not able to rename it, I had to create a new command in harmony hub from IR as a work around.

@nicoduj
Copy link
Owner

nicoduj commented Mar 2, 2021

Ok right, if it is a pre learned you can't renamed . Will fix that asap

@nicoduj
Copy link
Owner

nicoduj commented Apr 20, 2021

this one involves a lot of changes (probably going to json config instead of string based). Will postpone sorry.

@nicoduj nicoduj removed this from the 1.5.2 milestone Apr 20, 2021
@SSutherland94
Copy link

Hey all, was just wondering if there were any updates regarding this issue 😊

@nicoduj
Copy link
Owner

nicoduj commented Jul 7, 2021

Hi, like I said it involves a lot of changes in the plugin, and I don't have a lot of time to spend on it sorry.

@F-Kafka
Copy link

F-Kafka commented Feb 25, 2022

Sure would be nice if this could be fixed. I have a number of devices that suffer from this problem.

@JSVarga
Copy link

JSVarga commented Jun 10, 2022

Adding to this request, have the same issue for both zones of my Onkyo Amp.

@Morac2
Copy link
Contributor

Morac2 commented Sep 2, 2023

Running into the same problem with an Onkyo Amp.

Could this be worked around by adding a \ in front of the /?

@Morac2
Copy link
Contributor

Morac2 commented Sep 3, 2023

I changed the check in the code from / to \ and now I can add switches for commands with / in it.

That effectively changes the state control from slash to backslash, but I don’t care about that.

@Morac2 Morac2 mentioned this issue Mar 2, 2024
nicoduj added a commit that referenced this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants