Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional OSX icons #220

Open
mattrayner opened this issue May 3, 2024 · 5 comments
Open

Support additional OSX icons #220

mattrayner opened this issue May 3, 2024 · 5 comments

Comments

@mattrayner
Copy link

Hi, it would be cool if we could show OSX icons for additional keys:

  • Brightness Up (pause break)
  • Brightness Down (scroll lock)

Im happy to contribute a PR for this but have seen the closed source change you are making...

@nickcoutsos
Copy link
Owner

Good call, I should include the brightness keys. I'm using FontAwesome currently and taking a quick peek at the collection it seems that brightness up/down aren't included in the free set. I've had other such limitations and have been meaning to explore other icon sets so this is just more justification for that.

Could you clarify what you mean with the pause break and scroll lock in your parentheses? I'm looking at the ZMK Keycodes: Display table which just references HID codes. I'm on my MacBook where brightness are dedicated keys (touchbar, actually, bleh), are there fullsize external keyboards where those functions share the same keys?

@mattrayner
Copy link
Author

For OSX you typically use the keys SLCK for brightness down and PUSE_BREAK for brightness up as those keys are mapped by default at the OS level to brightness up and down

@mattrayner
Copy link
Author

Personally I'm moving to keymap-editor from Oryx and am just noting the 'differences', originally with the plan to commit back and improve, still happy to do that onto this repo if you wanted to then pull those changes forward onto your release?

@mattrayner
Copy link
Author

For example, C_NEXT and C_PREV would be good to have an icon for:

image

@mattrayner
Copy link
Author

Backlight controls could too:

image

Along with the Bluetooth control icons

Have you looked at material design icons (MDI) Material Design Icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants