From 1fc5c555788d2b503c9ff1f2a74a4c2bb9214deb Mon Sep 17 00:00:00 2001 From: Philipp Eder Date: Mon, 15 Apr 2024 12:07:13 +0200 Subject: [PATCH] Review findings --- .github/workflows/control.yml | 3 +-- release_tag.toml | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/control.yml b/.github/workflows/control.yml index e77ed84719..574d7b4303 100644 --- a/.github/workflows/control.yml +++ b/.github/workflows/control.yml @@ -109,8 +109,7 @@ jobs: permissions: contents: write # we release after container build so that we can release on a closed pr as we don't push the release container yet - # instead it is pushed after the tag is created. Maybe we should either change smoketests to not be dependent on a container push - # or push the newest container on release rather than on tag creation. + # instead it is pushed after the tag is created. # # For now we just don't use it as a dependency for releases which may is counter intuitive needs: [container, init] diff --git a/release_tag.toml b/release_tag.toml index e7b62ad595..bc00dc92a7 100644 --- a/release_tag.toml +++ b/release_tag.toml @@ -12,8 +12,8 @@ labels = [ # label within groups must be defined in `labels` groups = [ { group = "Added", label = "minor_release" }, - { group = "Changed", label = "major_release" }, # maybe minor? - { group = "Removed", label = "major_release" }, # maybe minor? + { group = "Changed", label = "major_release" }, + { group = "Removed", label = "major_release" }, { group = "Bug Fixes", label = "patch_release" }, ]