diff --git a/.github/workflows/control.yml b/.github/workflows/control.yml index e77ed8471..574d7b430 100644 --- a/.github/workflows/control.yml +++ b/.github/workflows/control.yml @@ -109,8 +109,7 @@ jobs: permissions: contents: write # we release after container build so that we can release on a closed pr as we don't push the release container yet - # instead it is pushed after the tag is created. Maybe we should either change smoketests to not be dependent on a container push - # or push the newest container on release rather than on tag creation. + # instead it is pushed after the tag is created. # # For now we just don't use it as a dependency for releases which may is counter intuitive needs: [container, init] diff --git a/release_tag.toml b/release_tag.toml index e7b62ad59..bc00dc92a 100644 --- a/release_tag.toml +++ b/release_tag.toml @@ -12,8 +12,8 @@ labels = [ # label within groups must be defined in `labels` groups = [ { group = "Added", label = "minor_release" }, - { group = "Changed", label = "major_release" }, # maybe minor? - { group = "Removed", label = "major_release" }, # maybe minor? + { group = "Changed", label = "major_release" }, + { group = "Removed", label = "major_release" }, { group = "Bug Fixes", label = "patch_release" }, ]