-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the OpenClipArt SVG library to the test suite #522
Comments
That's an good idea, especially thanks to the creative common license on the library, I might even be able to just put it in the repository. I put together a quick and dirty script to run the wgpu_svg example on all svg files in the library. Fortunately the main problem was in the wgpu_example code in the glue that turns the parser's path iterator into lyon's format. I'll look into making a more proper test harness and include this library. |
#523 takes care of all the failures in the openclipart library so I'll repurpose this issue for extending the test suite. |
I've filed an issue for the usvg error "SVG data parsing failed cause the document does not have a root node.": linebender/resvg#192 The rest of the failures ("SVG has an invalid size.", "SVG data parsing failed cause invalid token 'Declaration' at 1:1 cause expected '1.' at 1:16.") appear to be legitimate. |
Also note that |
When running the
wgpu_svg
example on the contents ofopenclipart-svg
Debian/Ubuntu package I see multiple occurrences of #521 as well as other errors such asError during tesselation!: Internal(IncorrectActiveEdgeOrder(4))
.Since these SVGs are real-world workloads and have already exposed multiple issues in Lyon, it seems wise to use them as a robustness and regression test going forward. If you're not on one of those distros, the dataset can be downloaded here: https://packages.ubuntu.com/bionic/openclipart
The text was updated successfully, but these errors were encountered: