Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable null value test for HTTP Get #666

Open
rajsite opened this issue Feb 12, 2020 · 0 comments
Open

Enable null value test for HTTP Get #666

rajsite opened this issue Feb 12, 2020 · 0 comments

Comments

@rajsite
Copy link
Member

rajsite commented Feb 12, 2020

A test that verified null values in the middle of binary HTTP Get response was allowed through was disabled in #665. The test relied on a seeded random string of binary bytes that contained a null value in the content.

The migration to Python 3 broke the seed in httpbin's /bytes endpoint as discussed here: postmanlabs/httpbin#598

In addition there are not other clear endpoints for httpbin that can return well-specified binary data. It seemed possible that the base64/ endpoint would allow that but this was not the case: postmanlabs/httpbin#599

We should find a way to reliably test round tripping null values in the HTTP Client library to avoid regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant