Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page templates page does not include correct folder path #96

Closed
vickytnz opened this issue Nov 7, 2024 · 2 comments · Fixed by #111
Closed

Page templates page does not include correct folder path #96

vickytnz opened this issue Nov 7, 2024 · 2 comments · Fixed by #111
Assignees
@frankieroberto
Labels
🐛 Bug Something isn't working Content Improvements or additions to documentation

Comments

@vickytnz
Copy link
Contributor

vickytnz commented Nov 7, 2024 •
edited by frankieroberto
Loading

Bug Report

What is the issue

The page templates page https://prototype-kit.service-manual.nhs.uk/page-templates has incorrect information for people using the prototype on their own computers - it does not live in /views/templates as suggested but /docs/views/templates

Suggested actions

  1. correct file path from /views/templates to docs/views/templates
@frankieroberto
Copy link
Contributor

Opps. Let's fix the paths and make all the links from the example templates just be href="#"?

Longer-term see #60 for giving this whole section a bit more thought.

@frankieroberto frankieroberto changed the title Make 'page templates' instructions work for people who are using the prototype on their own computers Page templates page does not include correct folder path Nov 13, 2024
@frankieroberto frankieroberto mentioned this issue Nov 13, 2024
Open
@frankieroberto
Copy link
Contributor

@vickytnz I've moved the link issue to #110 if that's ok, so that this issue can purely be about the error in the folder path.

@frankieroberto frankieroberto added the 🐛 Bug Something isn't working label Nov 13, 2024
@frankieroberto frankieroberto self-assigned this Nov 13, 2024
@frankieroberto frankieroberto mentioned this issue Nov 13, 2024
Merged
frankieroberto added a commit that referenced this issue Nov 18, 2024
@frankieroberto
Update page templates page (#111)
2292fcb 
This fixes the description of where the templates are located within the
kit, and adds a clearer description of how to use them.

Also removes the bullets from the lists and tweaks the heading sizes.

Fixes #96
@vickytnz vickytnz added the Content Improvements or additions to documentation label Nov 18, 2024
@vickytnz vickytnz mentioned this issue Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankieroberto frankieroberto

Labels
🐛 Bug Something isn't working Content Improvements or additions to documentation
Projects
NHS prototype kit project board (info in 'project details')
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update page templates page nhsuk/nhsuk.service-manual.prototype-kit.docs
2 participants
@frankieroberto @vickytnz