-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Modularization Support for tess4j (Module Descriptor module-info.java) #269
Comments
@astrapi69 Please submit a PR. Thanks. |
Hello @nguyenq, I have created and submitted a Pull Request to address the issue. The PR introduces a module-info.java file to provide modularization support for tess4j, ensuring compatibility with the Java Module System. It also updates the Maven Compiler Plugin configuration to target JDK 11. Please feel free to review the changes, and let me know if there are any adjustments or additional enhancements required. Thank you for considering this improvement, and I look forward to your feedback! |
@astrapi69 There was a warning during compile:
I think I'll need to modularize lept4j, but what about jai-imageio-core? How can it be addressed? Thanks. |
Hi @nguyenq may we can make a fork and modularize also jai-imageio-core. I just forked it now and will try to upgrade to jdk11 |
@astrapi69 I think it will need to be merged upstream to the original repo of jai-imageio-core, which hasn't received any code update for many years. Alternatively, we can use a more actively developed image library TwelveMonkeys; however, a PR related to modularization has also been stuck in the neutral the past few years. I probably will have to revert your PR to proceed with Tesseract 5.5.0 upgrade release. |
Hi @nguyenq, Thank you for your feedback and for pointing out the challenges with jai-imageio-core and lept4j. I completely understand the need to prioritize the Tesseract 5.5.0 upgrade release. To address these concerns: For jai-imageio-core: Alternatively, I can investigate replacing jai-imageio-core with TwelveMonkeys. While its modularization PR has been delayed, I will assess if this library offers better long-term compatibility and modernization for tess4j. For lept4j: Interim Solution: I hope these steps provide a clear path forward. Please let me know if there are any specific priorities or adjustments you'd like to see. Best regards, |
Hi @nguyenq,
I'm currently using tess4j in a modular Java project and encountered issues because tess4j lacks a module descriptor (module-info.java). Without it, I’m unable to include tess4j as a module in my project, which leads to errors such as error: Modul not found: tess4j requires tess4j;.
Proposed Solution:
Could you please consider adding modularization support for tess4j by including a module-info.java file? This would allow projects using the Java module system to include tess4j seamlessly as a required module.
An example of the required module descriptor might look like:
Benefits:
Thank you for considering this enhancement. Modularization would greatly improve compatibility and ease of use for Java developers working with the module system.
The text was updated successfully, but these errors were encountered: