We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No
When randPhoneNumber is used as randPhoneNumber({ countryCode: 'US' }) the numbers generated are at risk of not being actually valid numbers.
randPhoneNumber
randPhoneNumber({ countryCode: 'US' })
https://runkit.com/akkuma/65798236cdff300008bc8b3f
No errors or exceptions
node v20
Looking through the code it looks like the simplest solution would be to extend the formats on https://github.com/ngneat/falso/blob/main/packages/falso/src/lib/phone-number.json#L976 to be representative of a list like https://github.com/AfterShip/phone/blob/master/src/data/country_phone_data.ts#L2-L31. Alternatively, could use data like that to dynamically generate the mask formats as to not need to keep updating them.
Yes
The text was updated successfully, but these errors were encountered:
You're welcome to create a PR
Sorry, something went wrong.
No branches or pull requests
Is this a regression?
No
Description
When
randPhoneNumber
is used asrandPhoneNumber({ countryCode: 'US' })
the numbers generated are at risk of not being actually valid numbers.Please provide a link to a minimal reproduction of the bug
https://runkit.com/akkuma/65798236cdff300008bc8b3f
Please provide the exception or error you saw
Please provide the environment you discovered this bug in
Anything else?
Looking through the code it looks like the simplest solution would be to extend the formats on https://github.com/ngneat/falso/blob/main/packages/falso/src/lib/phone-number.json#L976 to be representative of a list like https://github.com/AfterShip/phone/blob/master/src/data/country_phone_data.ts#L2-L31. Alternatively, could use data like that to dynamically generate the mask formats as to not need to keep updating them.
Do you want to create a pull request?
Yes
The text was updated successfully, but these errors were encountered: