Add an opposite to upsert?

[zubko]

Hi,

I think it would be helpful to have an opposite updater to the upsert. upRemove, updateOrRemove?
The one that could update or remove the entity if some condition is met. I know it's pretty easy to make it in your own app if you need it, but if there is upsert then the counterpart is kinda asking to be there.

Like:

upRemoveEntitiesById(productId, {
      removePredicate: (item) => item.count <= 1,
      updater: (item) => ({ ...item, count: item.count - 1 }),
    })

I can add it if you agree.

Or maybe the regular update could accept undefined or null when the item should be removed?

Like:

updateEntities(productId, (item) => (item.count > 1 ? { ...item, item.count - 1 } : null))

[NetanelBasal]

We can go with the second approach, but I prefer to return a predefined symbol:

// from elf
export const REMOVE_ENTITY = Symbol()

// in the app
updateEntities(productId, (item) => (item.count > 1 ? { ...item, item.count - 1 } : REMOVE_ENTITY))

[NetanelBasal]

See how we can make it without affecting performance, please.

[zubko]

Thanks for the reply.

Great idea to use the symbol to make it super clear!

I'll experiment with that and share what I come up with.