Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): remove baseurl in fill and clip url #66

Closed
wants to merge 1 commit into from
Closed

fix(lib): remove baseurl in fill and clip url #66

wants to merge 1 commit into from

Conversation

Steven-Harris
Copy link

fixes #52

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 52

What is the new behavior?

BaseUrl doesn't not appear to be needed. uid used are already unique

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

BaseUrl doesn't not appear to be needed.

fixes #52
@Steven-Harris
Copy link
Author

no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with window.location.pathname
1 participant