Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"height" and "width" inputs removed in 5->6 and not documented as a breaking change #110

Open
tstackhouse opened this issue Sep 14, 2022 · 2 comments

Comments

@tstackhouse
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

We're in the process of upgrade from Angular 12 to 14, and are also upgrading our dependencies to the latest versions. We were using v4 of content loader, and bumped to v7. We're seeing build failures due to the use of the "height" and "width" inputs, which after investigating the code, were removed in v6. This breaking change was not documented, nor is an alternative suggested, so we will need to figure out how to maintain the expected behaviour without the benefit of documentation.

Expected behavior

Breaking changes to component inputs are documented and alternatives are potentially suggested, where reasonable.

Minimal reproduction of the problem with instructions

Use the <content-loader> component and attempt to set [height] and/or [width] inputs.

What is the motivation / use case for changing the behavior?

An undocumented breaking change makes for a poor developer experience when upgrading libraries.

Environment


Angular version: 14.2.0

Browser: N/A
 
For Tooling issues:
- Node version: 16.16.0
- Platform:  Linux

Others:
This is an Nx environment, fwiw, but that generally has no effect on 
@marcio199226
Copy link

Did you find a solution how to upgrade seamlessly and how to replace old height/width inputs ?

@marcio199226
Copy link

Ok nvm I figured out how to do it simply align viewBox width/height to old input's values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants