Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can settings.Run() (line 47) be moved with the other Go routine startups? #144

Open
ciroque opened this issue Nov 27, 2023 · 1 comment
Open

Comments

@ciroque
Copy link
Collaborator

ciroque commented Nov 27, 2023

the go settings.Run() call is done fairly early in main(). The original thought was this would give the Go routine time to load the certificates before the rest of the controller bits got up and running (sketchy trying to out-clever async code!).

However, the code was restructured to not wait for the inevitable callback from the Kubernetes API on startup, but rather to Read the targets before starting the listeners. This avoids a race condition and -- possibly? -- means the startup can be moved closer to the others.

Context: cmd/nginx-loadbalancer-kubernetes/main.go:47 go settings.Run()

@4141done
Copy link
Collaborator

What is the action here? Investigate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants