Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] randomOrder configuration parameter should fail if an invalid value is provided #204

Open
ngarbezza opened this issue Sep 25, 2021 · 4 comments
Assignees
Labels
bug Something isn't working ✨ dx ✨ improve developer experience good first issue Good for newcomers hacktoberfest

Comments

@ngarbezza
Copy link
Owner

Describe the bug
It seems that it is possible to configure Testy with an invalid value for the randomOrder configuration parameter, and it does not cause a failure.

Version(s) affected

To Reproduce

Run any suite with the following configuration in .testyrc.json:

{
  "directory": "./tests",
  "filter": ".*_test.js$",
  "language": "en",
  "failFast": false,
  "randomOrder": "I AM AN INVALID VALUE"
}

Expected behavior
An error message before running any suite explaining that the provided value is not valid, and the allowed values are true and false (booleans).

@ngarbezza ngarbezza added bug Something isn't working hacktoberfest labels Sep 25, 2021
@ngarbezza ngarbezza self-assigned this Sep 25, 2021
@ngarbezza ngarbezza added the good first issue Good for newcomers label Sep 25, 2021
@ngarbezza ngarbezza removed their assignment Sep 29, 2021
@zurda
Copy link

zurda commented Oct 2, 2021

Hi there, I'd love to do this one, if available.

@ngarbezza
Copy link
Owner Author

it's all yours @zurda !

@ngarbezza
Copy link
Owner Author

hi @zurda, just checking in: how it's your progress? did you run into any issues with the repo? let me know how can I help! thanks again for interesting in this repo 😄

@ignacio-r
Copy link
Contributor

Hi, assign this one to me if you want.

@ngarbezza ngarbezza assigned ignacio-r and unassigned zurda Aug 21, 2023
@ngarbezza ngarbezza added the ✨ dx ✨ improve developer experience label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ✨ dx ✨ improve developer experience good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants