-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can elasticgeo support sliced scroll-scan? #108
Comments
Hello. No it's not currently supported. |
Hi @sjudeng, I work with @johndeereguy and have some updates to ElasticFeatureReaderScroll and ElasticFeatureSource I'd like to prepare for a pull request. It adds support for a true ES Scroll so seems like it could apply to this issue (although not sliced). I have the changes in our version split from 2.12.2. Would this be helpful? And if so, which branch should I work to initially add changes to? Here's javadoc added to ElasticFeatureSource:
|
@halfstein I think this would be a great feature to add to the project. The documentation is great to see as well. Thanks for taking the time to contribute this back. You can target the master branch in this project. There's also a branch in my separate GeoTools fork here but I'd like to keep this project maintained until that's all merged and released. You're welcome to separately open a PR against the GeoTools branch and maybe we can get it included as part of that merge but I can also handle that later myself if that's inconvenient (the structure is very different). Thanks again for reaching out and for your work on this feature. |
@sjudeng great ... I'll start working on it. |
Also provides results greater than the ES max hits (default 10k), and perhaps address some of the enhancement request in issue ngageoint#108.
No description provided.
The text was updated successfully, but these errors were encountered: