feat: show deal info from w3up #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nft-storage with
|
| Latest commit: |
c20ac7d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34ae5703.nft-storage-1at.pages.dev |
| Branch Preview URL: | https://feat-w3up-deal-info.nft-storage-1at.pages.dev |
this seems to fix the build errors I was seeing, and necessitates a small code change
Add a test for fetching filecoin deal info from w3up. This is definitely not my best work - ideally we'd abstract this w3up mocking logic in a way that makes it less stateful, but I'm hesitant to do that when we will likely not be making many changes here in the future.
this broke existing tests because it was returning w3up deals in all situations
travis
commented
Apr 12, 2024
alanshaw
approved these changes
Apr 13, 2024
vasco-santos
approved these changes
Apr 15, 2024
travis
changed the title
Co-authored-by: Alan Shaw <[email protected]>
This was referenced Apr 15, 2024
travis
pushed a commit
that referenced
this pull request
Apr 17, 2024
🤖 I have created a release *beep* *boop* --- ## [4.8.0](api-v4.7.0...api-v4.8.0) (2024-04-17) ### Features * show deal info from w3up ([#2573](#2573)) ([766a7c1](766a7c1)) ### Bug Fixes * more logging of upload get fail ([#2593](#2593)) ([35cc344](35cc344)) * one more typo ([de5582e](de5582e)) ### Other Changes * more deals get debugging ([#2594](#2594)) ([36a26f1](36a26f1)) * remove debugging ([#2595](#2595)) ([3dc7916](3dc7916)) * remove legacy upload codepath ([#2580](#2580)) ([88c05a9](88c05a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis
pushed a commit
that referenced
this pull request
Apr 17, 2024
🤖 I have created a release *beep* *boop* --- ## [2.11.0](website-v2.10.0...website-v2.11.0) (2024-04-15) ### Features * show deal info from w3up ([#2573](#2573)) ([766a7c1](766a7c1)) * tweak readme ([#2563](#2563)) ([6a6298a](6a6298a)) ### Bug Fixes * use correct "nft get" endpoint ([#2589](#2589)) ([27632d8](27632d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch deal information from w3up.
There's no way to "multi-get" deal info for more than one upload so I've reworked the deal info in the files list - if it has deals from dagcargo it will just use those, and if it doesn't, it will display a "load deals" button:
When clicked, it will find the shards of the upload and find filecoin info for each of them. If it doesn't find any filecoin info in w3up it will display the "queuing" status and tooltip as it did in the past:
This required updating the "get NFT" API endpoint to look for filecoin info from w3up.