-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wawoff2 as the JS fallback ? #39
Comments
I am a bit curious about this. Can you give some details about the difference between Loving the set of tools that you're providing to convert font/svg 💕 In return, I am looking for a way to help you maintaining them 🙏 |
@nfroidure @puzrin I've noticed that the files that |
First, check if "smaller" file really works. I have no ideas about size. But i can say wawoff2 is binary equal to native woff2. It has appropriate fixtures to test. Since time is limited, i prefer a simple approach: "if result is binary equal to original, nobody cares about what happens inside". Try latest native woff2 1.0.3 version. If size is smaller than one by 1.0.2 (current wawoff2), i will update. |
Tbh, I do not use this set of tools anymore and anyone wanted to take the leadership on it is welcome. That said, I think the difference in weight may come from the fact the native sources were not updated since a long time. If I were to improve the font generation pipeline for myself, I think I would probably replace this plugin directly by its wasm implementation. |
@nfroidure @puzrin Both versions of However,
|
@roydukkey i just tested:
Ubuntu 18.04 LTS, node v10.11.0 Size is exactly as it should be, equal to other compressed files from your archive. |
@puzrin You're right. I found a typo in my code. :/ |
https://github.com/fontello/wawoff2
The text was updated successfully, but these errors were encountered: