Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for better test_indices #119

Open
ychong opened this issue Feb 8, 2018 · 3 comments
Open

Suggestion for better test_indices #119

ychong opened this issue Feb 8, 2018 · 3 comments
Assignees
Labels
enhancement good first issue If you want to contribute, this is a great place to start

Comments

@ychong
Copy link

ychong commented Feb 8, 2018

Hi I would like to propose a better implementation for 'test_indices':

We can remove the unneeded np.array casting:

Cleaner/New:
test_indices = list(set(range(len(texts))) - set(train_indices))

Old:
test_indices = np.array(list(set(range(len(texts))) - set(train_indices)))

@nfmcclure
Copy link
Owner

Thanks! I'll look into this. Do you know where specifically you want this changed?

@nfmcclure nfmcclure self-assigned this Mar 21, 2018
@ychong
Copy link
Author

ychong commented Jul 28, 2018

Hi Nick thanks for replying. Yes I didn't make it clear earlier. It's just clearer syntax. You can change it under Chapter 07 Neural Network - improving_linear_regression.py, and other similar implementation as well.

@nfmcclure nfmcclure added the good first issue If you want to contribute, this is a great place to start label Aug 19, 2018
@12744746
Copy link

12744746 commented Feb 8, 2020

Hi Everyone
could you please let me know for the classification part is the following data set suitable to build classification model for point Cloud.
https://shapenet.cs.stanford.edu/media/modelnet40_ply_hdf5_2048.zip,

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue If you want to contribute, this is a great place to start
Projects
None yet
Development

No branches or pull requests

3 participants