Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop accession workaround when nextstrain/augur 1384 is solved #32

Closed
Tracked by #29
joverlee521 opened this issue Feb 6, 2024 · 3 comments
Closed
Tracked by #29

Comments

@joverlee521
Copy link
Contributor

joverlee521 commented Feb 6, 2024

Originally from #28 (comment)

@j23414
Copy link
Contributor

j23414 commented Feb 24, 2024

A related #36 (comment) about "accession", "genbank_accession" and "url" so that we can hopefully group these changes in a PR.

@genehack
Copy link
Contributor

@joverlee521 @j23414 do we still need this issue? I'm having trouble understanding the context from the linked issues — if this is still relevant, could somebody please update the description to more directly indicate what changes need to be made?

@j23414
Copy link
Contributor

j23414 commented Nov 28, 2024

Can close this issue as we've dropped the "set_final_strain_name.py" script entirely during #72

I took a quick check and both "accession" and "USVI" links work in the node call out.

Screenshot 2024-11-28 at 8 00 50 AM Screenshot 2024-11-28 at 8 02 06 AM

@j23414 j23414 closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants