Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert /pathogens to App Router #1066

Open
genehack opened this issue Nov 13, 2024 · 3 comments
Open

Convert /pathogens to App Router #1066

genehack opened this issue Nov 13, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@genehack
Copy link
Contributor

genehack commented Nov 13, 2024

Context

This is part of the Convert static-site from Pages Router to App Router work. See there for additional context.

The /pathogens page uses only the GenericPage and ListResources components.

The GenericPage component is a simple bit of HTML and will be trivial to convert.

ListResources is a fairly massive component that uses some client-side state. On the plus side, it depends on very few things outside itself, and it has already been rewritten in Typescript (albeit, still making extensive use of Styled Components). Converting this component over is expected to be the bulk of the work.

@victorlin
Copy link
Member

I have some ListResources TypeScript work that I plan to make a PR for soon. Hopefully the app router work can wait for that.

@genehack
Copy link
Contributor Author

I have some ListResources TypeScript work that I plan to make a PR for soon. Hopefully the app router work can wait for that.

yeah, i'm gonna jump back into the blog PR and deal with the redirect issue there before i pick this back up — yesterday i got right to the point where i was gonna touch ListResources and ran out of day, so once that other PR is merged, i can rebase my WIP on top of it.

@victorlin
Copy link
Member

PR for the TypeScript work: #1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants