Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the docs build failures #209

Closed
4 tasks done
jameshadfield opened this issue Jun 17, 2024 · 11 comments
Closed
4 tasks done

Read the docs build failures #209

jameshadfield opened this issue Jun 17, 2024 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Jun 17, 2024

Upstream issue: readthedocs/readthedocs.org#11416

Progress

Repos affected were found using GitHub search for org:nextstrain python: "mambaforge-22.9".

Solutions/workarounds

  1. ⏳ Wait for upstream issue to be resolved
  2. ⛔️ Use python instead of mambaforge
  3. ⛔️ Pin to sphinx=7.2
  4. ✅ Bump the mambaforge version to 23.11

Initial commentary

We recently had multiple failures of the Read-the-docs build in Auspice PRs - nextstrain/auspice#1788, nextstrain/auspice#1779. There were no salient changes to docs related code in those PRs (I believe), and in all cases our action which builds the docs succeeded (example action log). Error (full log here):

critical libmamba Pathname can't be converted from UTF-8 to current locale.
Preparing transaction: ...working... done
Verifying transaction: ...working... failed

CondaVerificationError: The package for sphinx located at /home/docs/.asdf/installs/python/mambaforge-22.9.0-3/pkgs/sphinx-7.3.7-py312h5eee18b_0
appears to be corrupted. The path 'bin/sphinx-apidoc'
specified in the package manifest cannot be found.

CondaVerificationError: The package for sphinx located at /home/docs/.asdf/installs/python/mambaforge-22.9.0-3/pkgs/sphinx-7.3.7-py312h5eee18b_0
appears to be corrupted. The path 'bin/sphinx-autogen'
specified in the package manifest cannot be found.

...

The same failure occured on the latest/stable version of Auspice's RTD

@jameshadfield jameshadfield added the bug Something isn't working label Jun 17, 2024
@jameshadfield
Copy link
Member Author

The same failure observed in the latest Nextclade build so I'll transfer this issue...

@jameshadfield jameshadfield transferred this issue from nextstrain/auspice Jun 17, 2024
@jameshadfield
Copy link
Member Author

jameshadfield commented Jun 17, 2024

Nextstrain.org build just completed successfully however this uses python to build not mamba.

@tsibley
Copy link
Member

tsibley commented Jun 17, 2024

My first question is: What's the current locale for the RTD build system?

Driven by this error:

critical libmamba Pathname can't be converted from UTF-8 to current locale.

which I think is likely the root cause of all the other errors.

This feels like an RTD build system bug.

@tsibley
Copy link
Member

tsibley commented Jun 17, 2024

readthedocs/readthedocs.org#11416

@victorlin
Copy link
Member

I think these are the workarounds:

  1. Use python instead of mambaforge
  2. Pin to sphinx=7.2

I think (1) is too big and unnecessary of a change. (2) seems sensible with an inline comment.

@joverlee521
Copy link
Contributor

Latest build of docs in augur for nextstrain/augur#1493 completed successfully today.

@victorlin
Copy link
Member

Augur is not affected since, similar to nextstrain.org, it uses Python to build instead of mambaforge.

@victorlin
Copy link
Member

The upstream issue isn't getting any attention. I'll apply the workaround of pinning sphinx=7.2 to all affected repos.

@victorlin victorlin self-assigned this Jul 1, 2024
@victorlin
Copy link
Member

I just realized that docs.nextstrain.org is not actually affected as a side effect of the pin to docutils<0.18, which the broken Sphinx version is not compatible with. It'd still be good to pin sphinx separately.

Also, the pin shouldn't be sphinx=7.2 but a range with an upper cap. I pulled that directly from the upstream issue as a known workaround. Will do some testing to find the earliest version of Sphinx that breaks and cap it to lower than that.

@victorlin
Copy link
Member

Update❗️I found a better solution: bump the mambaforge version.

I did some searching on the error message and came across conda-forge/python-libarchive-c-feedstock#35 (comment). This is a known bug in mamba versions <1.4.7. The mambaforge version that we use across affected repos, 22.9, bundles mamba 1.1.0. The next available mambaforge version, 23.11, bundles mamba 1.5.5.

@victorlin
Copy link
Member

All RTD configs using mambaforge-22.9 have been updated to use mambaforge-23.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants