Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: Revisit updateTipRadii with tipSelectedIdx #1891

Open
victorlin opened this issue Nov 7, 2024 · 0 comments
Open

tree: Revisit updateTipRadii with tipSelectedIdx #1891

victorlin opened this issue Nov 7, 2024 · 0 comments

Comments

@victorlin
Copy link
Member

from #1864 (comment)

This code block:

auspice/src/actions/tree.js

Lines 218 to 224 in e8337a8

if (tipSelectedIdx) {
d.data = calcTipRadii({tipSelectedIdx, colorScale, tree});
if (tt) {
const idx = strainNameToIdx(treeToo.nodes, tree.nodes[tipSelectedIdx].name);
d.dataToo = calcTipRadii({idx, colorScale, tree: treeToo});
}
} else {

is unused because updateTipRadii is never called with a value for tipSelectedIdx.

Possible solutions

  1. Remove the code block
  2. Investigate the original intent and add a call that uses the code block
@victorlin victorlin mentioned this issue Nov 7, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant