Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maybe] differentiate between nodes with uncertainty vs nodes missing from colour scale #1797

Open
jameshadfield opened this issue Jul 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jameshadfield
Copy link
Member

Background

Nodes (branches & tips) will appear grey-er / de-saturated depending on their associated confidence/entropy, if available. Nodes (branches & tips) will be assigned a shade of grey if they are a non-continuous coloring where a colour scale has been provided however the node's value is not in the colour scale. It's very hard to distinguish between the two.

First raised in #1796:

[Jover] How would one be able to differentiate the grey scale for uncertainty vs grey scale for unprovided colorings? For example, imagine if zika's region had uncertainty, it would be mixed in with the "Asia" grey colorings.

[Trevor] The issue is that currently we use gray to mean either:

  • Unknown or uncertain
  • Uninteresting

This uninteresting take can be seen here https://nextstrain.org/ncov/gisaid/north-america/6m@2020-05-01 for example. This felt semantically appropriate to distinguish focal samples from background samples.
I think this is okay however... This example does DTA on samples with a focal vs contextual color ramp so that uncertain nodes and contextual nodes are both gray. This feels okay and appropriate (perhaps not ideal, but not broken). It highlights clades that are more certain to be in a focal region.

Description

We could pick a different fallback colour palette where a colour-scale is provided but certain values are missing (either unintentionally or intentionally)

@jameshadfield jameshadfield added the enhancement New feature or request label Jul 1, 2024
@joverlee521
Copy link
Contributor

Doesn't exactly solve the issue, but I like the idea of Value-Suppressing Uncertainty Palettes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants