-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "nuc" branch label option parallel to "aa" #1736
Comments
The way we do it now is for branch labels to be defined in the JSON, i.e. they're separate from the mutations defined on the branch. This isn't very efficient, but to see what this looks like for your dataset you can (and perhaps should) add these labels via a python script. I'd be in favor of allowing Auspice to automatically create aa & nuc labels from the mutations, thus forgoing the need for explicit branch labels for mutations. |
I thought the |
Yes. Here's the relevant code within
Oh, yes you're right: auspice/src/components/tree/phyloTree/labels.js Lines 57 to 60 in 40befc6
|
So it's a combination of special treatment by augur and auspice. Any reason we should auto-export nucs in augur export? Though I should probably transfer this issue over to augur then... |
I'd prefer to (or someone to) update Auspice to auto-generate these labels without needing to further bloat the JSON with duplicate nuc + aa mutation data. It shouldn't be too hard. In the meantime however adding a "nuc" branch label via a small script will allow you to see these data on the tree. Does that sound reasonable? Happy for others to weigh in here. |
Context
Automatic "aa" branch labels are useful. Sometimes it would be nice to show "nuc" branch labels instead, when there are branches without "aa"s in particular.
Description
Add "nuc" branch labels the way we have "aa" branch labels at the moment.
The text was updated successfully, but these errors were encountered: