Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "nuc" branch label option parallel to "aa" #1736

Open
corneliusroemer opened this issue Jan 16, 2024 · 5 comments
Open

Add "nuc" branch label option parallel to "aa" #1736

corneliusroemer opened this issue Jan 16, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

Context

Automatic "aa" branch labels are useful. Sometimes it would be nice to show "nuc" branch labels instead, when there are branches without "aa"s in particular.

Description

Add "nuc" branch labels the way we have "aa" branch labels at the moment.

image
@corneliusroemer corneliusroemer added the enhancement New feature or request label Jan 16, 2024
@jameshadfield
Copy link
Member

Add "nuc" branch labels the way we have "aa" branch labels at the moment.

The way we do it now is for branch labels to be defined in the JSON, i.e. they're separate from the mutations defined on the branch. This isn't very efficient, but to see what this looks like for your dataset you can (and perhaps should) add these labels via a python script.

I'd be in favor of allowing Auspice to automatically create aa & nuc labels from the mutations, thus forgoing the need for explicit branch labels for mutations.

@corneliusroemer
Copy link
Member Author

I thought the aa are done automatically in a way that nucs aren't? Maybe the automatic part for aa is in some augur command as opposed to auspice, is that what you're saying? There's a difference between manual branch labels like clade and whatnot and the magic "aa" which is always smaller font.

@jameshadfield
Copy link
Member

Maybe the automatic part for aa is in some augur command as opposed to auspice, is that what you're saying?

Yes. Here's the relevant code within augur export v2

the magic "aa" which is always smaller font.

Oh, yes you're right:

const branchLabelSize = (key) => {
if (key === "aa") return "10px";
return "14px";
};

@corneliusroemer
Copy link
Member Author

So it's a combination of special treatment by augur and auspice.

Any reason we should auto-export nucs in augur export? Though I should probably transfer this issue over to augur then...

@jameshadfield
Copy link
Member

jameshadfield commented Jan 17, 2024

Any reason we should auto-export nucs in augur export? Though I should probably transfer this issue over to augur then...

I'd prefer to (or someone to) update Auspice to auto-generate these labels without needing to further bloat the JSON with duplicate nuc + aa mutation data. It shouldn't be too hard. In the meantime however adding a "nuc" branch label via a small script will allow you to see these data on the tree. Does that sound reasonable? Happy for others to weigh in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants