Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported node versions #1553

Closed
jameshadfield opened this issue Sep 21, 2022 · 1 comment · Fixed by #1560
Closed

Update supported node versions #1553

jameshadfield opened this issue Sep 21, 2022 · 1 comment · Fixed by #1560
Assignees

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Sep 21, 2022

Currently our supported versions are "^12 || ^14 || ^16"

v12 has reached end-of-life and should be dropped

We should support v18. I'm running it day-to-day without problems, apart from needing the NODE_OPTIONS=--openssl-legacy-provider flag. My understanding is that this should go away with webpack 5, introduced in #1520.

@victorlin
Copy link
Member

Relatedly, I noticed that Auspice's Bioconda recipe is out of sync on Nodejs version compatibility. Opened a PR to fix it: bioconda/bioconda-recipes#37229

@victorlin victorlin moved this from New to Prioritized in Nextstrain planning (archived) Oct 5, 2022
victorlin added a commit to nextstrain/auspice.us that referenced this issue Oct 21, 2022
It's recommended to set the Node version explicitly¹, otherwise the
build server chooses a default which can change unexpectedly. For
example, this change was prompted because Heroku recently switched from
16 to 18. Auspice doesn't work on 18 yet², so we need to use 16.

¹ https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version
² nextstrain/auspice#1553
victorlin added a commit to nextstrain/auspice.us that referenced this issue Oct 21, 2022
It's recommended to set the Node version explicitly¹, otherwise the
build server chooses a default which can change unexpectedly. For
example, this change was prompted because Heroku recently switched from
16 to 18. Auspice doesn't work on 18 yet², so we need to use 16.

¹ https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version
² nextstrain/auspice#1553
@github-project-automation github-project-automation bot moved this from Prioritized to Done in Nextstrain planning (archived) Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants