Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narratives cannot zoom to selected (tree panel) #1284

Open
jameshadfield opened this issue Feb 11, 2021 · 4 comments · May be fixed by #1321
Open

Narratives cannot zoom to selected (tree panel) #1284

jameshadfield opened this issue Feb 11, 2021 · 4 comments · May be fixed by #1321
Labels
enhancement New feature or request please take this issue

Comments

@jameshadfield
Copy link
Member

Context

Auspice 2.21.0 introduced a "zoom to selected" button (via PR 1257.
This allows filtered trees to be zoomed to the subtree containing all the selected ("visible") tips.
This zooming requires user-interaction by clicking the "zoom to selected" button above the tree.

Clicking this button does not currently update the URL, however it should.
Because it does not modify the URL query, narratives cannot use this functionality.

Description
A test narrative has been added on branch bug-narratives-zoom-to-selected which introduces the problem and proposes a solution. To view this narrative:

git fetch && git checkout bug-narratives-zoom-to-selected
npm run get-data
auspice develop --narrativeDir narratives
# open http://localhost:4000/narratives/test/zoom-to-selected

Possible solution

Add ?treeZoom=selected to URL query. See narrative above for more details.
@jameshadfield jameshadfield linked a pull request Mar 30, 2021 that will close this issue
Open
@poisedleft
Copy link

I have a use case for this functionality. I was able to get it to work on a local auspice install using the feature branch. Is there any way to get it to work on a community build/when might the feature be merged into master?

@jameshadfield
Copy link
Member Author

@poisedleft absolutely! PR #1321 solves this, but it's not perfect (and hasn't been merged) so I would be interested in seeing your solution. It would be nice to get this functionality in.

@poisedleft
Copy link

Ok, this was working.. and now it's broken again (doesn't zoom). I think that's an issue with me running different auspice installs in different conda environments on the same box.. making a new environment worked before. But the narrative/data should be fine (though side question.. is this bugfix associated with a particular version number, so I can verify this?)

I ran from this branch.. it basically just has the narrative narratives/haiti_narrative.md and the data in haiti_data/ . Or if it's easier the same files are attached.

It would be great if this change can be merged into master. It's definitely not perfect.. notably, in order to zoom into a particular clade I had to manually define the relevant mutations. But I'm not sure how I would have done the presentation without it. I'm sharing some of this with people sooner rather than later, so the best way in the meantime is to spin up and expose my own server?

I've got other questions about both the data and the pipeline, but I'll ask them on the discussion board. Thanks for the bug-fix!

ncov_haiti_build_tip-frequencies.json.gz
haiti_narrative.md.gz
ncov_haiti_build.json.gz
ncov_haiti_build_root-sequence.json.gz

@poisedleft
Copy link

Ah.. so I did figure out how to zoom into a clade (instead of just selecting it).. that makes things useable, though the zoom is still better for some situations.

@joverlee521 joverlee521 mentioned this issue Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request please take this issue
Projects
No open projects
Nextstrain planning (archived)
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Zoom to selected is stored as a URL query nextstrain/auspice
2 participants
@jameshadfield @poisedleft