From ff0e7db0bbcdbadc24e8708c98123858e214d039 Mon Sep 17 00:00:00 2001 From: Victor Lin <13424970+victorlin@users.noreply.github.com> Date: Wed, 20 Nov 2024 17:47:12 -0800 Subject: [PATCH] Don't publish badly typed code Code that fails type-check should not be published, similarly to how code that fails linting is already not published. --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 7e39fc0cc..94f9b72d3 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -99,7 +99,7 @@ jobs: publish: if: ${{ github.ref == 'refs/heads/release' }} - needs: [build-and-smoke-test, unit-test, lint, check-lockfile] + needs: [build-and-smoke-test, unit-test, lint, type-check, check-lockfile] runs-on: ubuntu-latest steps: - uses: actions/checkout@v4