From a87c595fe239bcf42eb60fe213d373c923ae84eb Mon Sep 17 00:00:00 2001 From: james hadfield Date: Mon, 10 Jun 2024 19:33:58 +1200 Subject: [PATCH] [bugfix] typo in tree visibility property Oh how TypeScript would have helped! This bug was found while debugging the ability to show genotype colorings on both trees (added in the parent commit) where the visibility of the second tree was `undefined` upon loading, leading to `createVisibleLegendValues` not considering the second tree and thus removing legend items which were only observed in the second tree. Bug introduced ~4 years ago via 391bca4150415c61efcf2e8d3dde0786b7f0226c although its effect was minor (and probably never noticed?) --- src/actions/recomputeReduxState.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/actions/recomputeReduxState.js b/src/actions/recomputeReduxState.js index 5139fda7f..9a1f45d45 100644 --- a/src/actions/recomputeReduxState.js +++ b/src/actions/recomputeReduxState.js @@ -983,7 +983,7 @@ export const createStateFromQueryOrJSONs = ({ treeNodes: tree.nodes, treeTooNodes: treeToo ? treeToo.nodes : undefined, visibility: tree.visibility, - visibilityToo: treeToo ? treeToo.visibilityToo : undefined + visibilityToo: treeToo?.visibility, }); /* calculate entropy in view */