You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While we can "fix" this by propagating the exit status in devel/test, I don't think devel/test is really appropriate for CI/CD, at least in its current developer-focused form. Our release process should ideally use a very similar test setup as CI does, or even be part of the CI/CD workflow.
The text was updated successfully, but these errors were encountered:
The test step:
augur/.github/workflows/release.yaml
Line 28 in 227f526
doesn't error on test failures because
devel/test
masks the exit status:augur/devel/test
Lines 28 to 30 in 227f526
I noticed this with the 26.0.0 release just now, but it's been happening with past release workflow runs too.
While we can "fix" this by propagating the exit status in
devel/test
, I don't thinkdevel/test
is really appropriate for CI/CD, at least in its current developer-focused form. Our release process should ideally use a very similar test setup as CI does, or even be part of the CI/CD workflow.The text was updated successfully, but these errors were encountered: