-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: linkcheck fails occasionally due to fasttree link #1621
Comments
Yeah, see nextstrain/.github#106. |
Ah thanks. Why is this in the Ah I see, because the code lives there - not sure we shouldn't just keep this open here pointing at upstream? .github/workflows/docs-ci.yaml |
Right, the code lives there and the issue is more broad than Augur (though Augur is where we're most noticing the failures right now). I don't see the need for an open issue here; a closed one serves fine for searching purposes and doesn't clutter the open list. But if you'd like to leave it open, that's fine with me.
Searching across the org, e.g., rather than within a repo would be easier than searching two repos. |
Ah, the thing is the default of searching open issues is the easiest. I could search the org but it requires extra clicks I need to remember. Same for closed issue potentially, I would have to alter the default query. I think in principle it should stay open and be marked as "blocked" or "upstream" but this is bikeshedding process and I'm happy with whatever you prefer 😀 |
Current Behavior
I've noticed that linkcheck occasionally makes CI fail.
The only broken link I could find in logs is this:
https://github.com/nextstrain/augur/actions/runs/10706830674/job/29685454019#step:6:160
Update: seems just flaky, rerunning fixed it. Maybe we could wrap this step in a retry to deflake if it bothers us that CI fails stochastically.
The text was updated successfully, but these errors were encountered: