Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: linkcheck fails occasionally due to fasttree link #1621

Closed
corneliusroemer opened this issue Sep 4, 2024 · 4 comments
Closed

CI: linkcheck fails occasionally due to fasttree link #1621

corneliusroemer opened this issue Sep 4, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@corneliusroemer
Copy link
Member

corneliusroemer commented Sep 4, 2024

Current Behavior

I've noticed that linkcheck occasionally makes CI fail.

The only broken link I could find in logs is this:

(installation/installation: line    9) broken    http://www.microbesonline.org/fasttree/ - 403 Client Error: Forbidden for url: http://www.microbesonline.org/fasttree/

https://github.com/nextstrain/augur/actions/runs/10706830674/job/29685454019#step:6:160

Update: seems just flaky, rerunning fixed it. Maybe we could wrap this step in a retry to deflake if it bothers us that CI fails stochastically.

@corneliusroemer corneliusroemer added the bug Something isn't working label Sep 4, 2024
@tsibley
Copy link
Member

tsibley commented Sep 4, 2024

Yeah, see nextstrain/.github#106.

@tsibley tsibley closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
@corneliusroemer
Copy link
Member Author

corneliusroemer commented Sep 4, 2024

Ah thanks. Why is this in the .github repo rather than here in the repo that's actually affected? This means I need to check 2 rather than 1 repo for duplicates?

Ah I see, because the code lives there - not sure we shouldn't just keep this open here pointing at upstream? .github/workflows/docs-ci.yaml

@tsibley
Copy link
Member

tsibley commented Sep 5, 2024

Right, the code lives there and the issue is more broad than Augur (though Augur is where we're most noticing the failures right now). I don't see the need for an open issue here; a closed one serves fine for searching purposes and doesn't clutter the open list. But if you'd like to leave it open, that's fine with me.

This means I need to check 2 rather than 1 repo for duplicates?

Searching across the org, e.g., rather than within a repo would be easier than searching two repos.

@corneliusroemer
Copy link
Member Author

Ah, the thing is the default of searching open issues is the easiest. I could search the org but it requires extra clicks I need to remember.

Same for closed issue potentially, I would have to alter the default query. I think in principle it should stay open and be marked as "blocked" or "upstream" but this is bikeshedding process and I'm happy with whatever you prefer 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants