Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): remove share icon if listed in share-list #537

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

datenangebot
Copy link
Collaborator

@datenangebot datenangebot commented Sep 12, 2023

closes #530

SCR-20230912-jndi

@datenangebot datenangebot added this to the v0.6.0 milestone Sep 12, 2023
@datenangebot datenangebot requested review from a team, mejo-, luka-nextcloud and juliusknorr and removed request for a team September 12, 2023 08:22
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, why is eslint not complaining about the spaces

@juliusknorr
Copy link
Member

@datenangebot datenangebot merged commit 43bea1d into main Sep 12, 2023
9 checks passed
@datenangebot datenangebot deleted the fix/530-nav-share-icons branch September 12, 2023 08:50
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide share icon on shared tables in nav
2 participants