Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: No need to show toast messages on success #470

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix: No need to show toast messages on success #470

merged 2 commits into from
Aug 28, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 16, 2023 •
edited
Loading

As requested by @jancborchardt

The checkbox indicating the value is enough and we should only show a toast in an error case.

Fix #468

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Aug 16, 2023
@juliusknorr juliusknorr force-pushed the bugfix/noid/no-toast-on-success branch from 8eaaa67 to 5e28254 Compare August 16, 2023 19:07
@luka-nextcloud
Copy link
Contributor

luka-nextcloud commented Aug 18, 2023 •
edited
Loading

  1. I think it would be better to show a loading spinner until the operation is finished as suggested at Do not show toast on successful actions that are visibile in the UI #468
  2. this line should be removed also since toast was removed from sharing table.

@datenangebot datenangebot force-pushed the bugfix/noid/no-toast-on-success branch from 2df5ad1 to f4445ad Compare August 28, 2023 06:46
@datenangebot datenangebot enabled auto-merge (squash) August 28, 2023 06:56
@datenangebot datenangebot merged commit 3dcb518 into main Aug 28, 2023
9 checks passed
@datenangebot datenangebot deleted the bugfix/noid/no-toast-on-success branch August 28, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datenangebot datenangebot datenangebot approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not show toast on successful actions that are visibile in the UI
3 participants
@juliusknorr @luka-nextcloud @datenangebot