-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable local testability #5568
base: main
Are you sure you want to change the base?
Enable local testability #5568
Conversation
… with a build-context Signed-off-by: Apoorv Parle <[email protected]>
Signed-off-by: Apoorv Parle <[email protected]>
Hi @apparle thanks a lot for so many useful contributions! 😊 I just invited you to the repo to make collaboration easier :) |
btw this PR has some conflicts... |
Signed-off-by: Apoorv Parle <[email protected]>
…in Dockerfile Signed-off-by: Apoorv Parle <[email protected]>
Merged main and resolved conflicts. Also resolved lint issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use an environment variable like SKIP_DOMAIN_VALIDATION=true
But then it doesn't solve #5468 easily. It would be better to be able to skip the update temporarily rather than take everything down and restart with different env variables. (And then take it down again to remove the env variables when the reason-to-skip is resolved.) |
This PR enables the ability to build and test images locally. It does 2 things: