You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After filtering branch got this in suboptimal-issues:
The following commits were filtered out, but referenced in another
commit message. The reference to the now-nonexistent commit hash
(or a substring thereof) was left as-is in any commit messages:
b'c52b069e4be2d87a6d2f'
In my case the only place of mention of that hash is next commit message:
While the git-filter-repo source code comment says:
# A set of commit hash references appearing in commit messages which# mapped to a valid commit that was removed entirely in the filtering# process. The commit message will continue to reference the# now-missing commit hash, since there was nothing to map it to.self._commits_referenced_but_removed=set()
"valid commit that was removed entirely in the filtering", Karl 🤯
This hash never related to my git commit history and appears only in a web-url to a GitHub Gist 😂
Looks like code doesn't verify old commit hashes properly
The text was updated successfully, but these errors were encountered:
Yeah, seems to be more of a bug in the description than in the code logic; I think I assumed when I wrote the description that any hash-looking things would refer to commits and valid commits. It's not that I didn't verify old commit hashes properly, it's that I didn't do any verification and never pretended to and just assumed that's the only thing that would be mentioned. I could add some, I guess, or I could just update the description appropriately.
After filtering branch got this in
suboptimal-issues
:In my case the only place of mention of that hash is next commit message:
While the
git-filter-repo
source code comment says:"valid commit that was removed entirely in the filtering", Karl 🤯
This hash never related to my git commit history and appears only in a web-url to a GitHub Gist 😂
Looks like code doesn't verify old commit hashes properly
The text was updated successfully, but these errors were encountered: