Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High latency when querying thousands of Applications or Application Metrics #548

Open
kminehart opened this issue Nov 13, 2020 · 6 comments
Labels
bug Something isn't working client-go pinned Pin an issue to prevent auto-closing by a bot.

Comments

@kminehart
Copy link
Contributor

Description

In the rest implementation of the ApplicationsInterface, and in the APM struct, queries that are paginated traverse through every page before returning anything. Users of this package should have the ability to traverse through the pages themselves to avoid high latency requests.

This is happening a lot in the Grafana NewRelic datasource.

I'll be opening a pull request soon that ought to maintain backwards compatibility and add functions for retrieving individual pages, if that's ok. :)

@stale
Copy link

stale bot commented Nov 28, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue or PR has been inactive for a period of time. This label is configured in stale-bot. label Nov 28, 2020
@stale
Copy link

stale bot commented Dec 5, 2020

This issue has been automatically closed due to a lack of activity for an extended period of time.

@stale stale bot closed this as completed Dec 5, 2020
@jpvajda jpvajda added bug Something isn't working and removed stale Issue or PR has been inactive for a period of time. This label is configured in stale-bot. labels Dec 7, 2020
@jpvajda jpvajda self-assigned this Dec 7, 2020
@jpvajda
Copy link

jpvajda commented Dec 7, 2020

@kminehart Hello! This issue actually went stale, so apologies we didn't get back to you sooner, did you go ahead an open a PR for this change?

@kminehart
Copy link
Contributor Author

kminehart commented Dec 7, 2020

No actually I did not.

I started to, and then quickly realized that doing a change like this in a backwards compatible way that doesn't affect existing signatures that people are already using is really difficult.

I guess I needed to step away from it for a little bit because I realize now that it's totally doable. I'm not sure I'll have the time to make this change, but what I'd like to see if anyone is willing to pick this up is a function that allows us to control when the next page is requested when listing APM metrics.

@kminehart
Copy link
Contributor Author

Any chance we could get this reopened?

@jpvajda jpvajda reopened this Dec 7, 2020
@stale
Copy link

stale bot commented Dec 21, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue or PR has been inactive for a period of time. This label is configured in stale-bot. label Dec 21, 2020
@jpvajda jpvajda removed the stale Issue or PR has been inactive for a period of time. This label is configured in stale-bot. label Dec 21, 2020
@ctrombley ctrombley added the pinned Pin an issue to prevent auto-closing by a bot. label Dec 28, 2020
@jpvajda jpvajda removed their assignment May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client-go pinned Pin an issue to prevent auto-closing by a bot.
Projects
None yet
Development

No branches or pull requests

3 participants