Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect timeout to the collector should be higher #395

Open
mattbaker opened this issue Sep 23, 2022 · 0 comments
Open

Connect timeout to the collector should be higher #395

mattbaker opened this issue Sep 23, 2022 · 0 comments

Comments

@mattbaker
Copy link
Contributor

Other agents have an HTTP connect timeout as high as 2 minutes when they connect to the new relic collector. We should increase the timeout the agent uses for contacting the collector specifically.

Users can get around this by setting custom httpc options but that value is global and there could be cases where it causes a GenServer.call to timeout if another process is waiting a long time on an http connection and doesn't respond quickly enough.

Additional thoughts

  • The higher timeout should be specific to the collector code (for now)
  • We'll need to analyze how a higher timeout impacts other parts of the application. For example, if it causes a given genserver process to not response to messages while it waits then other parts of the agent may experience timeouts in their own calls to the process. This could lead to some weird bugs. The solution will need to include analyzing what other parts of the system may need to change to account for a higher connect timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant