Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Slow Queries #351

Open
andrewhr opened this issue Jun 14, 2021 · 6 comments
Open

Add support for Slow Queries #351

andrewhr opened this issue Jun 14, 2021 · 6 comments
Labels
feature request New feature or request

Comments

@andrewhr
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Current Agent export database queries, but they are only available as part of the Transaction traces. For other agents, like Ruby, we can also use the "Databases" tab, which includes query entries and can be really useful to diagnose issues in a way that the current support can't.

Describe the solution you'd like

Would be great if Elixir agent exports all data required for that section to work out-of-the-box. There is not specification AFAICT, otherwise we can work together to contribute a patch with that feature support.

Describe alternatives you've considered

Create custom instrumentation around Telemetry. It works, but doesn't integrate with overall NR experience.

@binaryseed
Copy link
Collaborator

This is fully supported in the agent already, what version are you running?

@andrewhr
Copy link
Contributor Author

The latest, but there is no slow queries on the panel. Maybe it's a flag I didn't activated?

@binaryseed
Copy link
Collaborator

Here's an app I run, do you see all this data on yours?

Cursor_and_Api_Key_Service__production____New_Relic_One

@andrewhr
Copy link
Contributor Author

I definitely didn't expressed that very well, sorry for the confusion.

Yes I do see this information. On the right panel, bellow the "Time consumption by caller" there is a "Slow queries" table which aggregates all slow queries for that entry. On a Ruby application we have, that works as expected - includes many queries and help to find spots where DBEs can work directly.

No Elixir app we have here (and most of them are Elixir) present data on that table, which I assume is not exported by the Agent.

It's more clear what I'm missing from the tool? Sorry again for the confusion! 🙇

@binaryseed
Copy link
Collaborator

Ahh yes, I see, you are asking specifically for "Slow Query" support which you are correct is not yet implemented in the agent.

@binaryseed binaryseed changed the title Add support for "Database" section of APM for Ecto Add support for Slow Queries Jun 14, 2021
@binaryseed binaryseed added the feature request New feature or request label Jun 14, 2021
@andrewhr
Copy link
Contributor Author

Thank you helping me clarify that, I appreciate 🙇!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants