New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLM support: how to specify the correct type?? #29

Open

DominiqueMakowski opened this issue Sep 9, 2018 · 0 comments

Labels

bug help us if you're reading this

Member

DominiqueMakowski commented Sep 9, 2018

Currently the functions are specified:

for LM: model_description(model::StatsModels.DataFrameRegressionModel{<:GLM.LinearModel}
for GLM: model_description(model::StatsModels.DataFrameRegressionModel{<:GLM.GeneralizedLinearModel})

However

for GLM, it should take into account the family (logistic etc.) which it doesn't currently
Critically, currently this doesn't work for GLM constructed without formulas:

y=[1:10;] 
X= hcat( fill(1,10), y.^2, y.^3 )
model= GLM.lm(X, y)

report(model)  # errors

as the type of this model is LinearModel{LmResp{Array{Float64,1}},DensePredChol{Float64,LinearAlgebra.Cholesky{Float64,Array{Float64,2}}}}.

How to specify the correct type for all of those cases?

The text was updated successfully, but these errors were encountered:

DominiqueMakowski added bug help us if you're reading this labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment