Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy units have been removed #35

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Legacy units have been removed #35

merged 1 commit into from
Oct 2, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Oct 1, 2023

No description provided.

@alkino alkino requested a review from iomaganaris October 1, 2023 14:13
pramodk
pramodk approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc: @nrnhines

@nrnhines nrnhines merged commit 8f7cf8f into master Oct 2, 2023
1 check passed
@nrnhines nrnhines deleted the cornu/remove_legacy_units branch October 2, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines approved these changes

@pramodk pramodk pramodk approved these changes

@iomaganaris iomaganaris Awaiting requested review from iomaganaris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @pramodk @nrnhines