On h.quit() terminal settings are same as when neuron.hoc was imported.

[nrnhines]

On h.quit() ensure terminal settings are same as when neuron.hoc was imported. This is most important with
NEURONMainMenu/File/Quit which would leave terminal in raw readline state with no input echoing and no return before linefeed when newline was printed. I.e. Consider the following when at the prompt, NEURONMainMenu/File/Quit is selected, and on exit, stty is typed at the terminal shell $ prompt (no echoing of stty)

$ python -i -c 'from neuron import h, gui'
>>> hines@hines-ThinkStation-P5:~/neuron/sane/bld$ 
speed 38400 baud; line = 0;
                           min = 1; time = 0;
                                             -imaxbel iutf8
                                                           -opost
                                                                 -icanon -iexten -echo

[azure-pipelines]

✔️ dd7514a -> Azure artifacts URL

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.08%. Comparing base (e0ab555) to head (6309927).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
src/nrnpython/inithoc.cpp	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3259      +/-   ##
==========================================
- Coverage   67.08%   67.08%   -0.01%     
==========================================
  Files         571      571              
  Lines      111116   111116              
==========================================
- Hits        74540    74539       -1     
- Misses      36576    36577       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[azure-pipelines]

✔️ 1c58958 -> Azure artifacts URL

[nrnhines]

@JCGoran I believe this prevents NEURONMainMenu/File/Quit from leaving the terminal in the raw input state (h.quit when python 3.13 readline is waiting for input). That problem was in both Linux and Macosx. When this is merged, I will look further into #3243

[azure-pipelines]

✔️ c8c5b7b -> Azure artifacts URL

[bbpbuildbot]

Logfiles from GitLab pipeline #239600 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[azure-pipelines]

✔️ 8ed8314 -> Azure artifacts URL

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[azure-pipelines]

✔️ 6309927 -> Azure artifacts URL

[JCGoran]

I think part of this was merged in #3243, but I guess the new isatty check is needed?

[nrnhines]

I think part of this was merged in #3243, but I guess the new isatty check is needed?

The check is needed to prevent an irrelevant error message(s) when stdin is not a terminal. For example, at the moment with the current master

$ echo 'from neuron import h;print("hello");h.quit()' | python
Error getting original terminal attributes
hello
Error restoring terminal attributes
$ 

[JCGoran]

Can confirm that this fixes the issue when we don't use stdin as input, so it's good to go.