Clean nocmodl_mod_to_cpp by doing sed in-place #3238
Conversation
|
| ${PROJECT_BINARY_DIR}/share/nrn/lib/nrnunits.lib | ||
| WORKING_DIRECTORY ${PROJECT_BINARY_DIR}/src/nrniv) | ||
| "${source_dir}/${modfile_basename}.mod" ${NRN_NMODL_--neuron} -o "${target_dir}" | ||
| COMMAND sed -i -e ${NOCMODL_SED_EXPR} "${target_dir}/${modfile_basename}.cpp" |
There was a problem hiding this comment.
I vaguely remember macs having special demands about -i.
There was a problem hiding this comment.
I like that it moves generated files into the build directory, we could bypass the issue by copying to $build_dir/$mod.cpp.tmp and then use sed to create $build_dir/$mod.cpp.
There was a problem hiding this comment.
When I did this patch the first time I vaguely remember that doing -i -e was how I fixed it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3238 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 569 569
Lines 111141 111141
=======================================
Hits 74549 74549
Misses 36592 36592 ☔ View full report in Codecov by Sentry. |
|
✔️ d6b84bf -> Azure artifacts URL |
No description provided.