New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IGNORE] Backport #3093 #3163

Draft

JCGoran wants to merge 2 commits into release/8.2 from jelic/backport_table

Collaborator

JCGoran commented Oct 31, 2024

Ignore this PR, I need a functioning wheel.

pramodk and others added 2 commits

October 31, 2024 13:15


          Backport #3093

16ab91d

- We were commenting TABLE statement from hh.mod as TABLE
  statement was not supported in mod2c.
- NMODL on CoreNEURON side supports TABLE statements also
  on GPU side.
- Hence, we can remove the CMake toggling logic for TABLE.
- Also update the references for tests in ringtest and testcorenrn repos

fixes #1764


          Yeah I don't need testing

cc5e7bb

sonarcloud bot commented Oct 31, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines bot commented Oct 31, 2024

✔️ cc5e7bb -> Azure artifacts URL

This was referenced Nov 5, 2024

Azure drop URL ignored neuronsimulator/nrn-modeldb-ci#135

Closed

Fix for certain modelDB CI failures #3194

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet