-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code in crout
#3060
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
✔️ b20be94 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3060 +/- ##
=======================================
Coverage 67.26% 67.26%
=======================================
Files 571 571
Lines 104885 104887 +2
=======================================
+ Hits 70550 70552 +2
Misses 34335 34335 ☔ View full report in Codecov by Sentry. |
I'm not opposed to cleaning this up. However, a disadvantage of removing the upper branch is that now the function is strange in that it kinda pretends that it has certain permutation functionality (via The existing has the advantage that it shows what should be happening if I feel this is a place where commenting the code might help. Something that explains that Or one could continue one step further and remove the argument |
@@ -132,56 +132,29 @@ inline void nrn_scopmath_solve_thread(int n, | |||
int* y, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
int* y, | |
int* /* y */, |
given the large number of macros, it's very hard to know if y
is really used or not.
/* | ||
* Note that the y vector is already in the correct order for back | ||
* substitution. Perform back substitution, pivoting the matrix but not | ||
* the y vector. There is no need to divide by the diagonal element as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't figure out what these sentences what to convey. Maybe they should be updated along with the doc string of the function.
The
if (0)
part should never execute. For reference, the first occurrence of it seems to be this commit: d5d03af