Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-sdp support configs/secrets as list of strings #1

Open
s4ke opened this issue Jun 11, 2022 · 1 comment
Open

docker-sdp support configs/secrets as list of strings #1

s4ke opened this issue Jun 11, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@s4ke
Copy link
Member

s4ke commented Jun 11, 2022

This does not work as it crashes the current code that expects a dictionary:

secrets:
   my_secret:
      file: /some/path

services:
   my_service:
      secrets:
         - my_secret

Instead one has to write

secrets:
   my_secret:
      file: /some/path

services:
   my_service:
      secrets:
         - source: my_secret
            target: my_secret

which will not work with the secret approach we currently take.

While we could rewrite the list to a dictionary, this feels like a bit much rewriting so we should instead throw a proper error that lets the user know that they should rewrite their yaml slightly.

@s4ke s4ke added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 29, 2022
@s4ke
Copy link
Member Author

s4ke commented May 22, 2023

Thinking about it, we should rewrite the "list of strings" style into a "list of mappings" style on the fly. It should be rather simple to do and will allow for easier usage by people coming from vanilla stack files which we aim to be compatible with anyways.

@s4ke s4ke changed the title docker-sdp should throw a better error if secrets listed as list docker-sdp support configs/secrets as list of strings May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant