Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor jinja2 codebase in jovo page #690

Open
jshinm opened this issue Dec 24, 2022 · 0 comments
Open

Refactor jinja2 codebase in jovo page #690

jshinm opened this issue Dec 24, 2022 · 0 comments
Assignees
@jshinm
Labels
maintenance 🔨 fix website discrepancies

Comments

@jshinm
Copy link
Collaborator

jshinm commented Dec 24, 2022

Currently, the same code is being copy-pasted multiple times which makes code update tedious. One possible way is to loop over a template.
@jshinm jshinm added the maintenance 🔨 fix website discrepancies label Dec 24, 2022
@jshinm jshinm mentioned this issue Dec 25, 2022
Merged
jshinm added a commit that referenced this issue Dec 25, 2022
@jshinm
Jovo CV update and modularizing codebase (#691)
29d1d03 
1000+ lines of code in jovo.html is modularized. Redundant code is replaced with partial html code snippet which is now being referenced from jovo.html. Also, main Jovo's CV content saved in jovo.html is saved as a distinct yaml file in content/pages. These changes reduced ~1.4k lines of code into ~350 lines.

This PR fixes #672 and #690, though there are more sections that could be optimized for issue #690.
@jshinm jshinm self-assigned this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshinm jshinm

Labels
maintenance 🔨 fix website discrepancies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jshinm