Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Auth: Replace HTTP Signature and consistency check #71

Open
12 of 13 tasks
melegiul opened this issue Mar 27, 2024 · 0 comments
Open
12 of 13 tasks

App Auth: Replace HTTP Signature and consistency check #71

melegiul opened this issue Mar 27, 2024 · 0 comments
Labels
component/mfa-app Native app authenticator component enhancement New feature or request

Comments

@melegiul
Copy link
Collaborator

See #63 (comment)

Most of it is already done. But still the HTTP Signatures replacement and the consistency check on setup (e.g. on setup a signature is sent and checked with the supplied public key) is open.

Open Issues

  • Replace HTTP Signatures with verification of client-side generated JWT
  • Verify code challenge on Action-Token-endpoint (authenticate) from the code_verifier query parameter

Todo

  • Delete login attempt/challenge after Action-Token-endpoint (for authenticate) was succesful called
  • Implement auto refresh of the Setup/Authenticate Keycloak page via Server Sent Events
  • Response payload of Get-Challenges-endpoint returns a list of challenges instead of a single one
  • Update Error Responses
  • Get Challenges and Reply Challenge Endpoint need to return the 409 error also when there is no login attempt. Otherweise the client does'nt know if the authenticator needs to get removed.
  • Remove OpenAPI spec
  • Rework documentation (readme)
  • Return clientName and clientUrl in payload of Get-Challenges-endpoint
  • Consistency check on setup
  • Reduce expiration for the app-auth-action-token to 60 seconds
  • Make expiration for app-auth-action-token configurable Admin UI
  • Rename attribute secret in Challenge DTO to codeChallenge
  • Remove device_id query parameter on Get-Challenges-endpoint retrieve it from the signature
@melegiul melegiul added the enhancement New feature or request label Mar 27, 2024
@svenseeberg svenseeberg added the component/mfa-app Native app authenticator component label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mfa-app Native app authenticator component enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants