Aruba AOS-CX Parser #172
Merged
Aruba AOS-CX Parser #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebates123
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
jeffkala
requested changes
Nov 11, 2022
lukebates123
requested review from
itdependsnetworks and
jeffkala
and removed request for
abates,
qduk and
itdependsnetworks
lukebates123
requested review from
itdependsnetworks and
jeffkala
and removed request for
jeffkala and
itdependsnetworks
jeffkala
reviewed
Nov 15, 2022
Co-authored-by: Jeff Kala <[email protected]>
lukebates123
requested review from
jeffkala and
itdependsnetworks
and removed request for
jeffkala
|
@lukebates123 great stuff! I/we need some time to review the code but it looks like you have done a great job. Approved GitHub actions so you can see if tests fail or not via CI now. (always run locally of course) |
jeffkala
approved these changes
Dec 15, 2022
itdependsnetworks
approved these changes
Dec 16, 2022
bminnix
pushed a commit
to bminnix/netutils
that referenced
this pull request
Feb 17, 2023
* add aruba to config parser * fix config parsing * remove unneeded line * add scrapli lookup mapper * aruba parser updates * add aruba_aoscx lib_mapper * Update netutils/config/parser.py Co-authored-by: Jeff Kala <[email protected]> * update test case Co-authored-by: lukebates123 <[email protected]> Co-authored-by: Jeff Kala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Aruba AOS-CX Parser.
I created tests based on the docs here https://netutils.readthedocs.io/en/latest/dev/dev_config/#new-parsers if there are additional tests needed let me know. This also addresses a request in #86