Citrix NetScaler Parser #153
Conversation
jdrew82
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
|
Do you mind rebasing and running tests? You will have to run the development script in the root of the directory to regen one of the docs. |
|
My branch has been rebased onto develop to pick up the documentation changes and I've run the development_scripts file and pushed the documentation update. Should be good to go now. |
tests/unit/mock/config/compliance/compliance/citrix_netscaler/netscaler_basic_feature.py
Show resolved
Hide resolved
tests/unit/mock/config/compliance/compliance/citrix_netscaler/netscaler_basic_backup.txt
Show resolved
Hide resolved
|
Also would be worthwhile based on the result of @itdependsnetworks comment above, if we don't want parent/child we should put a note similar to this for NetScaler. |
|
@jeffkala I've made a note in the documentation about the lack of parent/child relationships due to the configuration structure. I've also gone ahead and added the tests requested @itdependsnetworks. |
* feat: Add parser for Citrix NetScaler * test: ✅ Add compliance tests for NetScaler * docs: 📝 Update docs to add NetScaler parser to list * test: ✅ Add tests for cmdPolicy and ssl features * docs: 📝 Add documentation around parent/child missing in NS parser * docs: 📝 Fix indentation in documentation * revert: Revert indentation * revert: Revert deleted empty line Co-authored-by: Justin Drew <[email protected]>
This PR is for adding a Citrix NetScaler parser. I've included an example for the unit test and confirmed tests are passing. Please let me know if there are any other tests I need to write for this. This should address one of the requests in #86.